l i n u x - u s e r s - g r o u p - o f - d a v i s
L U G O D
 
Next Meeting:
November 4: Social gathering
Next Installfest:
TBD
Latest News:
Oct. 24: LUGOD election season has begun!
Page last updated:
2002 Jul 07 13:07

The following is an archive of a post made to our 'vox-tech mailing list' by one of its subscribers.

Report this post as spam:

(Enter your email address)
[vox-tech] lego USB tower module - the author speaks
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[vox-tech] lego USB tower module - the author speaks



hoo kay,

presumably you saw my email to the module author.  this was his
response.

pete


----- Forwarded message from Richard Lucock -----

From: Richard Lucock
Subject: Re: lego USB tower
To: p@dirac.org

Hi,

> loaded.  there are two curious things about the above output:
> first, lego was assigned minor number 0, when it should've taken 64.

        An error; 0 is the index into my local table, I forgot to add
the offset (64) when printing this message. By the way, the value for
the minor number will change when I get an official value, for the
moment I have just stolen the one for the rio500.

> second, the "device node registration failed" message is disheartening.

        Another error; the code shouldn't fail here, since a NULL
return just means that devfs is not in use (Since the kernel routine
devfs_register() is actually available on your system, I assume that
you are using a 2.4 or later kernel; I haven't really thought about
support for 2.2 or earlier).

        I have attached a patch for both of these errors.

Good luck,
        Richard


--- lego.c	Sun Jul  7 19:28:57 2002
+++ lego.c.orig	Mon Jul  1 22:30:31 2002
@@ -951,7 +951,7 @@
       goto probe_exit;
       }
 
-   info(__FUNCTION__ ": Allocated minor %d", lego_minor+LEGO_MINOR);
+   info(__FUNCTION__ ": Allocated minor %d", lego_minor);
 
    /* Private data for this instance */
 
@@ -1011,7 +1011,10 @@
    }
 
    if(lego->devfs == NULL)
-      dbg(__FUNCTION__ ": device node registration failed");
+      {
+      err(__FUNCTION__ ": device node registration failed");
+      goto probe_exit;
+      }
 
    init_MUTEX(&(lego->lock));
 




----- End forwarded message -----

-- 
GPG Fingerprint: B9F1 6CF3 47C4 7CD8 D33E  70A9 A3B9 1945 67EA 951D
_______________________________________________
vox-tech mailing list
vox-tech@lists.lugod.org
http://lists.lugod.org/mailman/listinfo/vox-tech



LinkedIn
LUGOD Group on LinkedIn
Sign up for LUGOD event announcements
Your email address:
facebook
LUGOD Group on Facebook
'Like' LUGOD on Facebook:

Hosting provided by:
Sunset Systems
Sunset Systems offers preconfigured Linux systems, remote system administration and custom software development.

LUGOD: Linux Users' Group of Davis
PO Box 2082, Davis, CA 95617
Contact Us

LUGOD is a 501(c)7 non-profit organization
based in Davis, California
and serving the Sacramento area.
"Linux" is a trademark of Linus Torvalds.

Sponsored in part by:
O'Reilly and Associates
For numerous book donations.